[webkit-reviews] review denied: [Bug 213036] [iOS] Skip rebuilding MobileGestalt cache if system is busy : [Attachment 401562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 10 12:43:45 PDT 2020


Geoffrey Garen <ggaren at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 213036: [iOS] Skip rebuilding MobileGestalt cache if system is busy
https://bugs.webkit.org/show_bug.cgi?id=213036

Attachment 401562: Patch

https://bugs.webkit.org/attachment.cgi?id=401562&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 401562
  --> https://bugs.webkit.org/attachment.cgi?id=401562
Patch

I don't think this is the right next step. It's true that, if IOKit reports it
is busy, then on some macOS builds MobileGestalt will hang for up to 5s before
rebuilding the cache. But, if we choose not to rebuild the cache in this state,
we'll reintroduce the bug where we can't render video (and possibly other
bugs).

Rather than trading a new regression for an old regression, I think we need to
come to a consensus on the right behavior here.


More information about the webkit-reviews mailing list