[webkit-reviews] review denied: [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch : [Attachment 401560] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 213037: Stop to use ActiveDOMObject::setPendingActivity() for
WebCore/Modules/fetch
https://bugs.webkit.org/show_bug.cgi?id=213037

Attachment 401560: Patch

https://bugs.webkit.org/attachment.cgi?id=401560&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 401560
  --> https://bugs.webkit.org/attachment.cgi?id=401560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401560&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:46
> +    , m_pendingActivity(nullptr)

Please remove. Not needed. RefPtr is initialized to nullptr without explicit
initialization.

> Source/WebCore/Modules/fetch/FetchBodyOwner.h:73
> +    void setPendingActivity()

Is there a reason these function bodies need to be entirely inlined in the
header? That seems like premature optimization. Let’s put them into the .cpp
file instead.

> Source/WebCore/Modules/fetch/FetchBodyOwner.h:85
> +    void unsetPendingActivity()
> +    {
> +	   if (m_pendingActivity)
> +	       m_pendingActivity->deref();
> +    }

This seems like it needs to ASSERT(m_pendingActivity), not just silently do
nothing.

This is wrong and will over-release. If you call setPendingActivity(), then
unsetPendingActivity(), and then delete the FetchBodyOwner, m_pendingActivity
will be ref'd once, but deref'd twice.

Explicit calls to ref/deref are almost never correct, and this shows one
example of why.