[webkit-reviews] review granted: [Bug 212996] WebKit:Add PepperUICoreSPI.h : [Attachment 401541] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 212996: WebKit:Add PepperUICoreSPI.h
https://bugs.webkit.org/show_bug.cgi?id=212996

Attachment 401541: Patch

https://bugs.webkit.org/attachment.cgi?id=401541&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401541
  --> https://bugs.webkit.org/attachment.cgi?id=401541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401541&action=review

> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:157
> + at property (nonatomic, assign) UIReturnKeyType returnKeyType; // Default is
Done, also supports Send and Join

I think we shouldn't be in the habit of importing comments from SPI headers.

> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:280
> + at property (nonatomic) BOOL useWideIdleCheck;

Do we really use all this stuff? I don't think so.