[webkit-reviews] review granted: [Bug 212981] Catalyst WebKit apps continue to play audio after quitting : [Attachment 401502] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 10 08:17:47 PDT 2020


Chris Dumez <cdumez at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 212981: Catalyst WebKit apps continue to play audio after quitting
https://bugs.webkit.org/show_bug.cgi?id=212981

Attachment 401502: Patch

https://bugs.webkit.org/attachment.cgi?id=401502&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 401502
  --> https://bugs.webkit.org/attachment.cgi?id=401502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401502&action=review

r=me

> Source/WebKit/UIProcess/EndowmentStateTracker.mm:129
> +    RELEASE_LOG(ViewState, "%p -
EndowmentStateTracker::setIsUserFacing(%s)", this, isUserFacing ? "true" :
"false");

%{public}s

> Source/WebKit/UIProcess/EndowmentStateTracker.mm:143
> +    RELEASE_LOG(ViewState, "%p - EndowmentStateTracker::setIsVisible(%s)",
this, isVisible ? "true" : "false");

%{public}s

> Source/WebKit/UIProcess/EndowmentStateTracker.mm:151
> +

Extra blank line here.


More information about the webkit-reviews mailing list