[webkit-reviews] review granted: [Bug 212994] WebKit: Add ClockKitSPI.h : [Attachment 401480] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 15:10:47 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 212994: WebKit: Add ClockKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=212994

Attachment 401480: Patch

https://bugs.webkit.org/attachment.cgi?id=401480&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 401480
  --> https://bugs.webkit.org/attachment.cgi?id=401480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401480&action=review

> Source/WebKit/ChangeLog:13
> +	   * UIProcess/ios/forms/WKTimePickerViewController.mm: Import
ClockKitSPI.h and UIkitSSPI.

Nit - “UIkitSSPI” => “UIKitSPI.h"

> Source/WebKit/Platform/spi/watchos/ClockKitSPI.h:46
> + at protocol CLKUIWheelsOfTimeDelegate <NSObject> @end

Nit - the @end should go on the next line.


More information about the webkit-reviews mailing list