[webkit-reviews] review granted: [Bug 212944] ComplexTextController: Use std::sort to calculate m_runIndices : [Attachment 401405] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 212944: ComplexTextController: Use std::sort to calculate m_runIndices
https://bugs.webkit.org/show_bug.cgi?id=212944

Attachment 401405: Patch

https://bugs.webkit.org/attachment.cgi?id=401405&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 401405
  --> https://bugs.webkit.org/attachment.cgi?id=401405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401405&action=review

This is probably okay. One perhaps unintended consequence is that these values
will no longer be computed lazily. However, most of the time, we iterate
through the entire ComplexTextController, so the laziness doesn't buy us much
in the common case. So I think this is fine.

> Source/WebCore/platform/graphics/ComplexTextController.cpp:156
> +	       m_runIndices.uncheckedAppend(length - i - 1);

This is kind of a neat idea. I like it.