[webkit-reviews] review denied: [Bug 212978] Use nonexistent.127.0.0.1 instead of nonexistent.localhost in our copy of wpt xhr tests : [Attachment 401453] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212978: Use nonexistent.127.0.0.1 instead of nonexistent.localhost in our
copy of wpt xhr tests
https://bugs.webkit.org/show_bug.cgi?id=212978

Attachment 401453: Patch

https://bugs.webkit.org/attachment.cgi?id=401453&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 401453
  --> https://bugs.webkit.org/attachment.cgi?id=401453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401453&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +	   We have some bots where a connection to nonexistent.localhost times
out instead of fails.
> +	   To cover this up, use a domain that will actually fail.

The tests still won't work as designed, because nonexistent.127.0.0.1 doesn't
resolve to loopback on macOS.

I think that WPT tests are written with this expired draft in mind
<https://tools.ietf.org/html/draft-west-let-localhost-be-localhost>, and work
on platforms where localhost subdomains resolve to loopback. This patch will
break that, because nonexistent.127.0.0.1 isn't supposed to work this way.