[webkit-reviews] review granted: [Bug 212970] BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit : [Attachment 401442] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 212970: BaseAudioSharedUnit should unmute its clients in case of suspension
even if not having any audio unit
https://bugs.webkit.org/show_bug.cgi?id=212970

Attachment 401442: Patch

https://bugs.webkit.org/attachment.cgi?id=401442&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 401442
  --> https://bugs.webkit.org/attachment.cgi?id=401442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401442&action=review

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:180
>      if (m_producingCount) {

This is confusing given the assert.