[webkit-reviews] review granted: [Bug 212967] scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure : [Attachment 401434] patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 212967: scrollingcoordinator/ios/scroll-position-after-reattach.html is a
flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=212967

Attachment 401434: patch

https://bugs.webkit.org/attachment.cgi?id=401434&action=review




--- Comment #3 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 401434
  --> https://bugs.webkit.org/attachment.cgi?id=401434
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>      let removed = outercontent;
>      outercontent.remove();

While you're modifying this test, you can remove the `removed` variable which
is useless, `outercontent` can be used.

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:36
> +    await new Promise(requestAnimationFrame);

Since this test is already pulling in `UIHelper`, you can use
`UIHelper.animationFrame()`.