[webkit-reviews] review denied: [Bug 212649] Multiple SVG Filters Unexpectedly lightens image using linearRGB : [Attachment 401395] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied guowei_yang at apple.com's
request for review:
Bug 212649: Multiple SVG Filters Unexpectedly lightens image using linearRGB
https://bugs.webkit.org/show_bug.cgi?id=212649

Attachment 401395: Patch

https://bugs.webkit.org/attachment.cgi?id=401395&action=review




--- Comment #33 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 401395
  --> https://bugs.webkit.org/attachment.cgi?id=401395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401395&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:607
> +    if (usesCGPlatform()) {

Agree with other comments that say this could be a #if USE(CG). Or maybe the CG
behavior should be the default, and the other ports should be fixed; after all,
doing colorspace conversion on painting is something any reasonable graphics
framework should be able to do.