[webkit-reviews] review granted: [Bug 212928] TextManipulation should only convert text from Node's text content to tokens : [Attachment 401408] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 212928: TextManipulation should only convert text from Node's text content
to tokens
https://bugs.webkit.org/show_bug.cgi?id=212928

Attachment 401408: Patch

https://bugs.webkit.org/attachment.cgi?id=401408&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 401408
  --> https://bugs.webkit.org/attachment.cgi?id=401408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401408&action=review

> Source/WebCore/editing/TextManipulationController.cpp:234
> +		   if (contiansDelimiter) {

Nit - contiansDelimiter => containsDelimiter

> Source/WebCore/editing/TextManipulationController.cpp:329
> +TextManipulationController::ManipulationUnit
TextManipulationController::createUnit(const Vector<String>& text, Node*
textNode)

Maybe make this take `Node& textNode`, since we never expect it to be null?