[webkit-reviews] review granted: [Bug 212940] REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash : [Attachment 401399] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 212940: REGRESSION: [Safari Mojave for High Sierra] Accessing some of the
featured pages on apple.com causes the webpage to crash
https://bugs.webkit.org/show_bug.cgi?id=212940

Attachment 401399: Patch

https://bugs.webkit.org/attachment.cgi?id=401399&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401399
  --> https://bugs.webkit.org/attachment.cgi?id=401399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
> +    static bool hasSingleton() { return !!m_singleton; }

The alternative is "singletonIfExists()" or whatever. I think we have a pattern
for this.