[webkit-reviews] review granted: [Bug 212918] Extended Color: Switch ColorMac.mm's nsColor() function over to using TinyLRUCache : [Attachment 401397] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 212918: Extended Color: Switch ColorMac.mm's nsColor() function over to
using TinyLRUCache
https://bugs.webkit.org/show_bug.cgi?id=212918

Attachment 401397: Patch

https://bugs.webkit.org/attachment.cgi?id=401397&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 401397
  --> https://bugs.webkit.org/attachment.cgi?id=401397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401397&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:142
> +    ASSERT(color.isExtended() || color.asSimple().value());

Do we need to write this assertion? Will TinyLRUCache automatically assert the
same thing for us?

> Source/WebCore/platform/graphics/mac/ColorMac.mm:145
> +    return cache.get().get(color).get();

"get, get, get"

Better than "kvetch, kvetch, kvetch" I guess.