[webkit-reviews] review granted: [Bug 212932] WebKit.ShrinkToFit is failing on some bots : [Attachment 401389] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 15:59:48 PDT 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 212932: WebKit.ShrinkToFit is failing on some bots
https://bugs.webkit.org/show_bug.cgi?id=212932
Attachment 401389: Patch
https://bugs.webkit.org/attachment.cgi?id=401389&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 401389
--> https://bugs.webkit.org/attachment.cgi?id=401389
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401389&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:66
> + // This is 85 instead of 100 because we now have a scrollbar.
Does the "now" refer to "after this fix" or "now that the test has done
something"? Remove it if the former.
More information about the webkit-reviews
mailing list