[webkit-reviews] review granted: [Bug 212704] HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of PLATFORM(IOS_FAMILY) but only checks the version of __IPHONE_OS_VERSION_MIN_REQUIRED : [Attachment 401380] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 212704: HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of
PLATFORM(IOS_FAMILY) but only checks the version of
__IPHONE_OS_VERSION_MIN_REQUIRED
https://bugs.webkit.org/show_bug.cgi?id=212704

Attachment 401380: patch

https://bugs.webkit.org/attachment.cgi?id=401380&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 401380
  --> https://bugs.webkit.org/attachment.cgi?id=401380
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401380&action=review

> Source/WTF/wtf/PlatformHave.h:388
> -#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000
> +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \
> +    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 70000) \
> +    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 140000)

Seems like an improvement. Also note that in IOS_FAMILY, besides iOS, watchOS,
and tvOS, there is Mac Catalyst.