[webkit-reviews] review granted: [Bug 212921] [IPC] Adopt enum class for IPC::CFType : [Attachment 401383] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 15:46:11 PDT 2020

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 212921: [IPC] Adopt enum class for IPC::CFType

Attachment 401383: Patch v2


--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 401383
  --> https://bugs.webkit.org/attachment.cgi?id=401383
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=401383&action=review

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:55
>      CFArray,

I understand your rationale for wanting to leave the CF prefix on these, but I
don’t agree that it’s better to have that mechanical rule and I would remove it
if it was me doing the work.

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:181
> +    case CFType::Unknown:

Seems like someone should later refactor to eliminate this value. Using
Optional, most likely. It’s funny to validate that these are good values, but
include one bad value.

> Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:210
> +    RetainPtr<CFDictionaryRef> dictionary =

I’d use auto here.

> Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:234
> +    RetainPtr<NSURLRequest> nsURLRequest =

And here.

> Source/WebKit/mac/WebKit2.order:919
> -__ZN7CoreIPC16tokenNullTypeRefEv
> +__ZN7CoreIPC19tokenNullptrTypeRefEv

Normally we don’t try to keep these up to date. Not even sure why we still have
them checked in.

More information about the webkit-reviews mailing list