[webkit-reviews] review canceled: [Bug 212921] [IPC] Adopt enum class for IPC::CFType : [Attachment 401369] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 212921: [IPC] Adopt enum class for IPC::CFType
https://bugs.webkit.org/show_bug.cgi?id=212921

Attachment 401369: Patch v1

https://bugs.webkit.org/attachment.cgi?id=401369&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 401369
  --> https://bugs.webkit.org/attachment.cgi?id=401369
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=401369&action=review

>>> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:54
>>> +enum class CFType : uint8_t {
>> 
>> We should take off all the CF prefixes for the enumeration values.
> 
> Except that it seems we have null and CFNull!?

Seems like it's to differentiate between a CFNull object and a nullptr.