[webkit-reviews] review granted: [Bug 211978] Add a timeout monitor for JSC stress test : [Attachment 401368] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 211978: Add a timeout monitor for JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=211978

Attachment 401368: Patch

https://bugs.webkit.org/attachment.cgi?id=401368&action=review




--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 401368
  --> https://bugs.webkit.org/attachment.cgi?id=401368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401368&action=review

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:239
> +	   timeout = ENV['JSCTEST_timeout'].to_i + 10 # let jsc timeout handler
trigger first

I'm surprised the style-checker is happy with this.

'Seconds' and 'Let jsc timeout...' should have their first leter capitalized

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:259
> +    echo "#{Shellwords.shellescape(@name)} has time out, killing with
timeout monitor"

Should be "has timed out"