[webkit-reviews] review granted: [Bug 212872] Extended Color: Replace uses of differenceSquared() with luminance based computations : [Attachment 401307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 11:23:24 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 212872: Extended Color: Replace uses of differenceSquared() with luminance
based computations
https://bugs.webkit.org/show_bug.cgi?id=212872

Attachment 401307: Patch

https://bugs.webkit.org/attachment.cgi?id=401307&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 401307
  --> https://bugs.webkit.org/attachment.cgi?id=401307
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401307&action=review

> Source/WebCore/platform/graphics/Color.h:139
> +    WEBCORE_EXPORT Color lighten() const;
> +    WEBCORE_EXPORT Color darken() const;

A Cocoa-style name would be lightened/darkened or lightened/darkenedColor.


More information about the webkit-reviews mailing list