[webkit-reviews] review granted: [Bug 212689] [EME] CDMProxyInstance should not keep CDMInstanceSessions hard referenced : [Attachment 401333] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 08:58:25 PDT 2020
youenn fablet <youennf at gmail.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 212689: [EME] CDMProxyInstance should not keep CDMInstanceSessions hard
referenced
https://bugs.webkit.org/show_bug.cgi?id=212689
Attachment 401333: Patch
https://bugs.webkit.org/attachment.cgi?id=401333&action=review
--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 401333
--> https://bugs.webkit.org/attachment.cgi?id=401333
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401333&action=review
> Source/WebCore/platform/encryptedmedia/CDMProxy.cpp:319
> + m_sessions.add(session);
It seems m_sessions is only used here.
Can we even go further and remove m_sessions?
More information about the webkit-reviews
mailing list