[webkit-reviews] review requested: [Bug 212689] [EME] CDMProxyInstance should not keep CDMInstanceSessions hard referenced : [Attachment 401333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 07:34:14 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 212689: [EME] CDMProxyInstance should not keep CDMInstanceSessions hard
referenced
https://bugs.webkit.org/show_bug.cgi?id=212689

Attachment 401333: Patch

https://bugs.webkit.org/attachment.cgi?id=401333&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 401333

  --> https://bugs.webkit.org/attachment.cgi?id=401333&action=review

Patch

(In reply to youenn fablet from comment #7)
> > Source/WebCore/testing/Internals.h:53
> > +#include "MediaKeys.h"
> 
> Can we forward declare MediaKeySession and MediaKeys?

Nope, compiler complains.

The rest is handled.


More information about the webkit-reviews mailing list