[webkit-reviews] review granted: [Bug 212529] [WebXR] Pass an unsigned long to cancelAnimationCallback() as handle : [Attachment 400595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 01:07:28 PDT 2020


youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 212529: [WebXR] Pass an unsigned long to cancelAnimationCallback() as
handle
https://bugs.webkit.org/show_bug.cgi?id=212529

Attachment 400595: Patch

https://bugs.webkit.org/attachment.cgi?id=400595&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 400595
  --> https://bugs.webkit.org/attachment.cgi?id=400595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400595&action=review

> Source/WebCore/Modules/webxr/WebXRSession.cpp:212
> +void WebXRSession::cancelAnimationFrame(XRFrameRequestCallback::Id
callbackId)

I would call it XRFrameRequestCallback::Identifier


More information about the webkit-reviews mailing list