[webkit-reviews] review granted: [Bug 212869] [LFC] Add support for width: min/max-content : [Attachment 401263] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 6 09:39:28 PDT 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 212869: [LFC] Add support for width: min/max-content
https://bugs.webkit.org/show_bug.cgi?id=212869

Attachment 401263: Patch

https://bugs.webkit.org/attachment.cgi?id=401263&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 401263
  --> https://bugs.webkit.org/attachment.cgi?id=401263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401263&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:107
> +    auto width = widthType == WidthType::Normal ? style.logicalWidth() :
widthType == WidthType::Min ? style.logicalMinWidth() :
style.logicalMaxWidth();

a lambda might be more readable


More information about the webkit-reviews mailing list