[webkit-reviews] review granted: [Bug 212458] Crash when running web-apis data collection : [Attachment 401253] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 6 07:28:33 PDT 2020
Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 212458: Crash when running web-apis data collection
https://bugs.webkit.org/show_bug.cgi?id=212458
Attachment 401253: Patch
https://bugs.webkit.org/attachment.cgi?id=401253&action=review
--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 401253
--> https://bugs.webkit.org/attachment.cgi?id=401253
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401253&action=review
r=me
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4341
> + push(@implContent, " putDirectCustomAccessor(vm,
static_cast<JSVMClientData*>(vm.clientData)->builtinNames()." . $attributeName
. "PublicName(), CustomGetterSetter::create(vm, $getter, $setter),
attributesForStructure($jscAttributes));\n");
Can you also add a bindings test case for this?
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4467
> + if (IsAcceleratedDOMAttribute($interface, $attribute)) {
Can you add bindings test for these 2 cases as well?
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4487
> + if (IsAcceleratedDOMAttribute($interface, $attribute)) {
Is it possible to add a bindings test for these 2 cases of PrivateName
DOMAttributeGetterSetter and CustomGetterSetter?
More information about the webkit-reviews
mailing list