[webkit-reviews] review granted: [Bug 212855] WebKitLegacy: Link to framework stubs for watchOS and tvOS : [Attachment 401214] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 212855: WebKitLegacy: Link to framework stubs for watchOS and tvOS
https://bugs.webkit.org/show_bug.cgi?id=212855

Attachment 401214: Patch

https://bugs.webkit.org/attachment.cgi?id=401214&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401214
  --> https://bugs.webkit.org/attachment.cgi?id=401214
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401214&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42
> +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR)
$(WK_PRIVATE_FRAMEWORKS_DIR);
> +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR)
"$(UMBRELLA_FRAMEWORKS_DIR)";

I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch" but
also sdk=macosx* is the reason I removed all the SDK conditionals back in the
day). Maybe it's OK?