[webkit-reviews] review granted: [Bug 207043] Generalize configure-xcode-for-ios-development : [Attachment 401059] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 207043: Generalize configure-xcode-for-ios-development
https://bugs.webkit.org/show_bug.cgi?id=207043

Attachment 401059: Patch

https://bugs.webkit.org/attachment.cgi?id=401059&action=review




--- Comment #10 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 401059
  --> https://bugs.webkit.org/attachment.cgi?id=401059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401059&action=review

rs=me

I did not try to compare logic from the old script to the new one.  The best
test would be to run each script and verify output is identical (equivalent)
for a given SDK.

> Tools/Scripts/configure-xcode-for-embedded-development:1
> +#!/usr/bin/env python3

We aren't supporting Python 2.7 in new scripts anymore?

> Tools/Scripts/configure-xcode-for-embedded-development:3
> +# Copyright (C) 2020 Apple Inc.  All rights reserved.

Nit:  Since this is based on the Perl script, should the copyright be from
2014-2020?

# Copyright (C) 2014, 2015 Apple Inc. All rights reserved.