[webkit-reviews] review granted: [Bug 212739] File URLs with hostnames are misleading : [Attachment 401127] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 212739: File URLs with hostnames are misleading
https://bugs.webkit.org/show_bug.cgi?id=212739

Attachment 401127: Patch

https://bugs.webkit.org/attachment.cgi?id=401127&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 401127
  --> https://bugs.webkit.org/attachment.cgi?id=401127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401127&action=review

seems reasonable.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:337
> +	   TestWebKitAPI::Util::sleep(0.1);

spinRunLoop might be nicer here.  It could save almost 1/10 of a second each
time this test is run.