[webkit-reviews] review granted: [Bug 212834] WebCore: Link to framework stubs for watchOS and tvOS : [Attachment 401173] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 212834: WebCore: Link to framework stubs for watchOS and tvOS
https://bugs.webkit.org/show_bug.cgi?id=212834

Attachment 401173: Patch

https://bugs.webkit.org/attachment.cgi?id=401173&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401173
  --> https://bugs.webkit.org/attachment.cgi?id=401173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

> Source/WebCore/Configurations/Base.xcconfig:79
> +GCC_WARN_64_TO_32_BIT_CONVERSION[arch=i386] = NO;

Wonder why we have it on at all at this point. Also, how did we not need this
when we had 32-bit macOS builds?