[webkit-reviews] review granted: [Bug 212830] -_focusTextInputContext should reposition the caret if called for an already focused text input context : [Attachment 401169] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 5 10:21:18 PDT 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 212830: -_focusTextInputContext should reposition the caret if called for
an already focused text input context
https://bugs.webkit.org/show_bug.cgi?id=212830
Attachment 401169: Patch
https://bugs.webkit.org/attachment.cgi?id=401169&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 401169
--> https://bugs.webkit.org/attachment.cgi?id=401169
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=401169&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4297
> + _pointInsideLastFocusedTextInputContext = WTF::nullopt;
Should we also reset this in `-cleanUpInteraction`?
More information about the webkit-reviews
mailing list