[webkit-reviews] review granted: [Bug 212796] WTF: Exclude MachExceptions.defs from all embedded builds : [Attachment 401113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 20:48:00 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 212796: WTF: Exclude MachExceptions.defs from all embedded builds
https://bugs.webkit.org/show_bug.cgi?id=212796

Attachment 401113: Patch

https://bugs.webkit.org/attachment.cgi?id=401113&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 401113
  --> https://bugs.webkit.org/attachment.cgi?id=401113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review

> Source/WTF/ChangeLog:10
> +2020-06-04  Jonathan Bedard	<jbedard at apple.com>

Extra change log.

> Source/WTF/Configurations/WTF.xcconfig:-35
> -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited)
$(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks

This seems unrelated.

> Source/WTF/Configurations/WTF.xcconfig:32
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] =
$(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK));

This includes simulator, correct?


More information about the webkit-reviews mailing list