[webkit-reviews] review granted: [Bug 212795] Add WKUIDelegate SPI to confirm before opening a PDF : [Attachment 401106] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212795: Add WKUIDelegate SPI to confirm before opening a PDF
https://bugs.webkit.org/show_bug.cgi?id=212795

Attachment 401106: Patch

https://bugs.webkit.org/attachment.cgi?id=401106&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 401106
  --> https://bugs.webkit.org/attachment.cgi?id=401106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401106&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:118
> +- (void)_webView:(WKWebView *)webView
confirmPDFOpeningFromFrame:(WKFrameInfo *)frame completionHandler:(void
(^)(BOOL))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA),
ios(WK_IOS_TBA));

I don't love the name. I don't have a great alternative.

shouldAllowPDFToOpenFromFrame? canOpenPDFFromFrame?

> Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:510
> +    FileSystem::setMetadataURL(nsPath.get(), originatingURLString);

Nice