[webkit-reviews] review granted: [Bug 207075] Audit safe to execute : [Attachment 400984] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 207075: Audit safe to execute
https://bugs.webkit.org/show_bug.cgi?id=207075

Attachment 400984: patch

https://bugs.webkit.org/attachment.cgi?id=400984&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 400984
  --> https://bugs.webkit.org/attachment.cgi?id=400984
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400984&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSafeToExecute.h:487
> +	   bool isSafe = true;
> +	   const ClassInfo* classInfo = node->requiredDOMJITClassInfo();
> +	   structures.forEach([&] (RegisteredStructure structure) {
> +	       isSafe &= structure->classInfo()->isSubClassOf(classInfo);
> +	   });
> +	   return isSafe;
> +    }

What happens if structure set is empty?