[webkit-reviews] review denied: [Bug 212415] WebKit Crashes when SVG Filter Logging is Turned On : [Attachment 401045] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied guowei_yang at apple.com's
request for review:
Bug 212415: WebKit Crashes when SVG Filter Logging is Turned On
https://bugs.webkit.org/show_bug.cgi?id=212415

Attachment 401045: Patch

https://bugs.webkit.org/attachment.cgi?id=401045&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 401045
  --> https://bugs.webkit.org/attachment.cgi?id=401045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401045&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:284
> +    StringBuilder builder;
> +    StringPrintStream logStream;
> +    logStream.printf("FilterEffect %s %p %s(). Existing image buffer %p",
filterName(), this, resultType, m_imageBufferResult.get());
> +    
> +    if (m_premultipliedImageResult)
> +	   logStream.printf(" m_premultipliedImageResult %p ",
m_premultipliedImageResult->data());
> +    else
> +	   logStream.printf(" m_premultipliedImageResult %p", nullptr);
> +	   
> +    if (m_unmultipliedImageResult)
> +	   logStream.printf(" m_unmultipliedImageResult %p",
m_unmultipliedImageResult->data());
> +    else
> +	   logStream.printf(" m_unmultipliedImageResult %p", nullptr);
> +    builder.append(logStream.toString());
> +    
> +    return builder.toString();

This seems worse than the original. 

Implement TextStream& operator<<(TextStream&, const ImageBuffer&)

then use ValueOrNull() in the logging.