[webkit-reviews] review granted: [Bug 212765] Add a Thread Specific Buffer for LinkBuffer when Compacting : [Attachment 401067] Patch for landing

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted	review:
Bug 212765: Add a Thread Specific Buffer for LinkBuffer when Compacting
https://bugs.webkit.org/show_bug.cgi?id=212765

Attachment 401067: Patch for landing

https://bugs.webkit.org/attachment.cgi?id=401067&action=review




--- Comment #4 from Michael Saboff <msaboff at apple.com> ---
Created attachment 401067

  --> https://bugs.webkit.org/attachment.cgi?id=401067&action=review

Patch for landing

> > Source/JavaScriptCore/assembler/LinkBuffer.cpp:125
> > +typedef ThreadSpecific<BranchCompactionLinkBuffer,
WTF::CanBeGCThread::True> ThreadSpecificBranchCompactionLinkBuffer;
> 
> nit: "using" instead of "typedef"

Done.

> > Source/JavaScriptCore/assembler/LinkBuffer.cpp:201
> > +	 uint8_t* m_data;
> > +	 size_t m_size;
> 
> nit: you can give these fields default values so you don't have to
> initialize them in 2 different ctors

Done.