[webkit-reviews] review granted: [Bug 212734] Reduce DFGDoesGCCheck to only storing a uint32_t. : [Attachment 401043] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 12:27:26 PDT 2020


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 212734: Reduce DFGDoesGCCheck to only storing a uint32_t.
https://bugs.webkit.org/show_bug.cgi?id=212734

Attachment 401043: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=401043&action=review




--- Comment #20 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 401043
  --> https://bugs.webkit.org/attachment.cgi?id=401043
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=401043&action=review

> Source/JavaScriptCore/ChangeLog:28
> +	   This patch also makes ENABLE_DFG_DOES_GC_VALIDATION dependent on
ENABLE(DFG_JIT).

can we also add a runtime flag for this to make it easy not to clutter the
emitted assembly on debug builds?


More information about the webkit-reviews mailing list