[webkit-reviews] review granted: [Bug 212765] Add a Thread Specific Buffer for LinkBuffer when Compacting : [Attachment 401051] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 212765: Add a Thread Specific Buffer for LinkBuffer when Compacting
https://bugs.webkit.org/show_bug.cgi?id=212765

Attachment 401051: Patch

https://bugs.webkit.org/attachment.cgi?id=401051&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 401051
  --> https://bugs.webkit.org/attachment.cgi?id=401051
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401051&action=review

r=me

> Source/JavaScriptCore/assembler/LinkBuffer.cpp:125
> +typedef ThreadSpecific<BranchCompactionLinkBuffer, WTF::CanBeGCThread::True>
ThreadSpecificBranchCompactionLinkBuffer;

nit: "using" instead of "typedef"

> Source/JavaScriptCore/assembler/LinkBuffer.cpp:201
> +    uint8_t* m_data;
> +    size_t m_size;

nit: you can give these fields default values so you don't have to initialize
them in 2 different ctors

> Source/JavaScriptCore/assembler/LinkBuffer.cpp:232
> +    BranchCompactionLinkBuffer outBuffer(m_size);

can we do the FAST_JIT_PERMISSIONS&&arm64e path above in a runtime supported
way for other devices too? Seems purely better than this, since it doesn't
require a side buffer.

There are a few arm64 devices that at runtime support APRR

Maybe as a follow-up in a separate patch