[webkit-reviews] review granted: [Bug 212758] [IPC] Adopt EnumTraits and enum class for PluginProcessType and PluginProcessSandboxPolicy : [Attachment 401057] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 212758: [IPC] Adopt EnumTraits and enum class for PluginProcessType and
PluginProcessSandboxPolicy
https://bugs.webkit.org/show_bug.cgi?id=212758

Attachment 401057: Patch v1

https://bugs.webkit.org/attachment.cgi?id=401057&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 401057
  --> https://bugs.webkit.org/attachment.cgi?id=401057
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=401057&action=review

> Source/WebKit/Shared/Plugins/PluginProcessAttributes.h:33
> +enum class PluginProcessType : uint8_t {

How did you choose uint8_t vs. bool for this?

> Source/WebKit/Shared/Plugins/PluginProcessAttributes.h:38
> +enum class PluginProcessSandboxPolicy : uint8_t {

Ditto.