[webkit-reviews] review granted: [Bug 212649] Multiple SVG Filters Unexpectedly lightens image using linearRGB : [Attachment 401033] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted guowei_yang at apple.com's
request for review:
Bug 212649: Multiple SVG Filters Unexpectedly lightens image using linearRGB
https://bugs.webkit.org/show_bug.cgi?id=212649

Attachment 401033: Patch

https://bugs.webkit.org/attachment.cgi?id=401033&action=review




--- Comment #16 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 401033
  --> https://bugs.webkit.org/attachment.cgi?id=401033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401033&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:512
> +		   copyConvertedImageBufferResult(destination, rect,
AlphaPremultiplication::Premultiplied, colorSpace);

It looks like the color space is only used if the enum is set to Required.
Should it just be Optional<ColorSpace> With a default value of Nullopt instead?