[webkit-reviews] review denied: [Bug 206431] [JSC] Add support for private class fields : [Attachment 400579] Patch v21.6

[bugzilla-daemon at webkit.org]

Caio Lima <ticaiolima at gmail.com> has denied Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 206431: [JSC] Add support for private class fields
https://bugs.webkit.org/show_bug.cgi?id=206431

Attachment 400579: Patch v21.6

https://bugs.webkit.org/attachment.cgi?id=400579&action=review




--- Comment #49 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 400579
  --> https://bugs.webkit.org/attachment.cgi?id=400579
Patch v21.6

View in context: https://bugs.webkit.org/attachment.cgi?id=400579&action=review

I'm setting r- because I've found a bug into Baseline JIT for PutByValDirect
changes. It is also necessary to include DFG changes to take in consideration
`PrivateFieldAccessKind` of `put_by_val_direct`. The patch as it is will
compile a `put_by_val_direct <receiver, probably 'this'>, <symbol>, <value>,
<PutByValPrivateName>`	as it is `put_by_val_direct <receiver, probably
'this'>, <symbol>, <value>, <None>`.

> Source/JavaScriptCore/jit/JITPropertyAccess.cpp:305
>	   base = bytecode.m_base;

We are missing here changes to consider new added flags for Private fields.