[webkit-reviews] review denied: [Bug 212649] Multiple SVG Filters Unexpectedly lightens image using linearRGB : [Attachment 400859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 10:54:13 PDT 2020


Sam Weinig <sam at webkit.org> has denied guowei_yang at apple.com's request for
review:
Bug 212649: Multiple SVG Filters Unexpectedly lightens image using linearRGB
https://bugs.webkit.org/show_bug.cgi?id=212649

Attachment 400859: Patch

https://bugs.webkit.org/attachment.cgi?id=400859&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 400859
  --> https://bugs.webkit.org/attachment.cgi?id=400859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400859&action=review

> Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:128
> +#if USE(CG)
> +    in->copyUnmultipliedResult(*pixelArray, drawingRect, true,
operatingColorSpace());
> +#else
> +    in->copyUnmultipliedResult(*pixelArray, drawingRect, false);
> +#endif

Why is this being done for CG only? Your ChangeLog does not indicate what makes
this problem CG specific.


More information about the webkit-reviews mailing list