[webkit-reviews] review denied: [Bug 212608] Any active sqlite transactions for the ITP database should be aborted when the network process suspends. : [Attachment 400873] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied katherine_cheney at apple.com's request
for review:
Bug 212608: Any active sqlite transactions for the ITP database should be
aborted when the network process suspends.
https://bugs.webkit.org/show_bug.cgi?id=212608

Attachment 400873: Patch

https://bugs.webkit.org/attachment.cgi?id=400873&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 400873
  --> https://bugs.webkit.org/attachment.cgi?id=400873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400873&action=review

Please add a static allStores() function to ResourceLoadStatisticsDatabaseStore
and move the logic there. Then you add to the HashSet in the
ResourceLoadStatisticsDatabaseStore constructor and remove in the
ResourceLoadStatisticsDatabaseStore destructor.

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:178
> +    static NeverDestroyed<HashMap<WebResourceLoadStatisticsStore*,
ResourceLoadStatisticsDatabaseStore*>> map;

Why isn't this a HashSet<ResourceLoadStatisticsDatabaseStore*> ?

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:179
> +    return map;

I would ASSERT(!RunLoop::isMain()); in here.

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:199
> +		   statisticsDatabaseStoreMap().add(this,
downcast<ResourceLoadStatisticsDatabaseStore>(m_statisticsStore.get()));

You add but never remove.