[webkit-reviews] review granted: [Bug 212685] dataTransfer.types is empty when handling the "dragstart" event : [Attachment 400900] For EWS

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 212685: dataTransfer.types is empty when handling the "dragstart" event
https://bugs.webkit.org/show_bug.cgi?id=212685

Attachment 400900: For EWS

https://bugs.webkit.org/attachment.cgi?id=400900&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 400900
  --> https://bugs.webkit.org/attachment.cgi?id=400900
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=400900&action=review

> Source/WebCore/platform/StaticPasteboard.cpp:104
> +    m_customData.writeString("text/html", markup);

Could append _s to the string literal.

> Source/WebCore/platform/StaticPasteboard.cpp:109
> +    m_customData.writeString("text/plain", text);

Ditto.

> Source/WebCore/platform/StaticPasteboard.cpp:114
> +    m_customData.writeString("text/uri-list", url.url.string());

Ditto.