[webkit-reviews] review granted: [Bug 212680] Enhance DoesGC verification to print more useful info when verification fails. : [Attachment 400889] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 212680: Enhance DoesGC verification to print more useful info when
verification fails.
https://bugs.webkit.org/show_bug.cgi?id=212680

Attachment 400889: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=400889&action=review




--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 400889
  --> https://bugs.webkit.org/attachment.cgi?id=400889
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=400889&action=review

r=me with comment

> Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:988
>  
> +    void store64(TrustedImm64 imm, void* address)
> +    {
> +	   auto src = scratchRegister();
> +	   move(imm, src);
> +	   swap(src, X86Registers::eax);
> +	   m_assembler.movq_EAXm(address);
> +	   swap(src, X86Registers::eax);
> +    }
> +

Why not just doing the same thing to `void store64(TrustedImm64 imm,
ImplicitAddress address)`?