[webkit-reviews] review granted: [Bug 212619] [iOS] WKProcessAssertionBackgroundTaskManager incorrectly ignores expiration notifications for daemons : [Attachment 400830] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 212619: [iOS] WKProcessAssertionBackgroundTaskManager incorrectly ignores
expiration notifications for daemons
https://bugs.webkit.org/show_bug.cgi?id=212619

Attachment 400830: Patch

https://bugs.webkit.org/attachment.cgi?id=400830&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 400830
  --> https://bugs.webkit.org/attachment.cgi?id=400830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400830&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:53
> +    return [[[RBSProcessHandle currentProcess] activeLimitations] runTime]
!= RBSProcessTimeLimitationNone;

It might be worth putting this inside a std::call_once, because this should
never change, right?

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:241
> +    auto remainingTime = [[[RBSProcessHandle currentProcess]
activeLimitations] runTime];

Can we use dot syntax for any of this?