[webkit-reviews] review denied: [Bug 212608] Any active sqlite transactions for the ITP database should be aborted when the network process suspends. : [Attachment 400755] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 2 16:20:31 PDT 2020


Chris Dumez <cdumez at apple.com> has denied katherine_cheney at apple.com's request
for review:
Bug 212608: Any active sqlite transactions for the ITP database should be
aborted when the network process suspends.
https://bugs.webkit.org/show_bug.cgi?id=212608

Attachment 400755: Patch

https://bugs.webkit.org/attachment.cgi?id=400755&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 400755
  --> https://bugs.webkit.org/attachment.cgi?id=400755
Patch

I am 90% sure this is wrong and re-introducing a bug that we fixed recently. I
am a bit sad that the API tests are not failing since I think we added a test
to cover that. The reason WebResourceLoadStatisticsStore was static was that
there is only one shared queue nowadays. You don't want to go through every
store and hang each queue separately because they all share the same queue..


More information about the webkit-reviews mailing list