[webkit-reviews] review granted: [Bug 212646] Crash with uncaught exception: *** -[AVSampleBufferAudioRenderer enqueueSampleBuffer:] Sample buffer has media type 'vide' instead of 'soun' : [Attachment 400839] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 212646: Crash with uncaught exception: *** -[AVSampleBufferAudioRenderer
enqueueSampleBuffer:] Sample buffer has media type 'vide' instead of 'soun'
https://bugs.webkit.org/show_bug.cgi?id=212646

Attachment 400839: Patch

https://bugs.webkit.org/attachment.cgi?id=400839&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 400839
  --> https://bugs.webkit.org/attachment.cgi?id=400839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400839&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1140
> +	   // AVSampleBufferDisplayLayer will throw an un-documented exception
is passed a sample

s/is/if/

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1206
> +	   // AVSampleBufferAudioRenderer will throw an un-documented exception
is passed a sample

Ditto