[webkit-reviews] review granted: [Bug 212634] REGRESSION(r261387): Introduced sandbox violations : [Attachment 400819] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 212634: REGRESSION(r261387): Introduced sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=212634

Attachment 400819: Patch

https://bugs.webkit.org/attachment.cgi?id=400819&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 400819
  --> https://bugs.webkit.org/attachment.cgi?id=400819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400819&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:181
> +	   auto connection = [objc_getClass("_LSDReadService")
XPCConnectionToService];
> +	   [connection invalidate];

How do we know this is the only connection we need to close? Seems very
magical.

Also seems unnecessary to use a local variable here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:186
>	   ASSERT(String(uti.get()) =
String(adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType,
CFSTR("text/html"), 0)).get()));

This assertion is using assignment ("="), not an equality check ("==").