[webkit-reviews] review granted: [Bug 212631] UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors : [Attachment 400798] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 212631: UIColor and NSColor WebCore::Color factories should return invalid
colors for nil input colors
https://bugs.webkit.org/show_bug.cgi?id=212631

Attachment 400798: Patch

https://bugs.webkit.org/attachment.cgi?id=400798&action=review




--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 400798
  --> https://bugs.webkit.org/attachment.cgi?id=400798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400798&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:98
> +	   return Color();

Can probably just return { } here.

> Source/WebCore/platform/graphics/mac/ColorMac.mm:108
> +	   return Color();

Same.

> Source/WebCore/platform/ios/ColorIOS.mm:38
> +	   return Color();

Same.