[webkit-reviews] review granted: [Bug 211178] [GTK4] Make popup menus work : [Attachment 400806] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 211178: [GTK4] Make popup menus work
https://bugs.webkit.org/show_bug.cgi?id=211178

Attachment 400806: Patch

https://bugs.webkit.org/attachment.cgi?id=400806&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 400806
  --> https://bugs.webkit.org/attachment.cgi?id=400806
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400806&action=review

> Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:335
> +    GdkRectangle windowRect = { rect.x(), rect.y(), rect.width(),
rect.height() };

This exact same line is repeated below, so I would take it out of
the “#if USE(GTK4)” guard.