[webkit-reviews] review granted: [Bug 212614] Add a helper method to populate a DataTransfer before dispatching a "dragstart" event : [Attachment 400773] Fix WinCairo build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 212614: Add a helper method to populate a DataTransfer before dispatching a
"dragstart" event
https://bugs.webkit.org/show_bug.cgi?id=212614

Attachment 400773: Fix WinCairo build

https://bugs.webkit.org/attachment.cgi?id=400773&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 400773
  --> https://bugs.webkit.org/attachment.cgi?id=400773
Fix WinCairo build

View in context: https://bugs.webkit.org/attachment.cgi?id=400773&action=review

> Source/WebCore/ChangeLog:11
> +	   dispatching the "dragstart" event. There should be no change in
behavior yet, since StaticPasteboard doesn't
> +	   implement methods for writing data to the pasteboard, which this new
method uses.

This feels oddly backwards (landing the patch that does nothing because it
calls unimplemented methods). But I assume the follow-up is coming shortly?

> Source/WebCore/page/DragController.cpp:965
> +    auto hitTestResult = hitTestResultForDragStart(src, *state.source,
dragOrigin);

Are we hit testing twice now? Must we?